Remove unnecessary uses of extend T::Sig
#3257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
(we still need it some places for `abstract!`)
andyw8
force-pushed
the
andyw8/remove-unnecessary-t-sigs
branch
from
0dd1269 to
cc70e47
Compare
Morriar
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch to RBS inline sigs means we don't need this, except for places for that use
abstract!(but hopefully that will also be solved).One potential issue is that if an add-on uses Sorbet
sigs, and inherit from something in Ruby LSP which previously extendedT::Sig, the add-on author will need to add thatextend T::Sigcall into their class. The add-on would be very broken without that, so it should be hard to miss, but it might add a little confusion.