Assorted RBS grammar fixes #3275
Merged
+29
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morriar
added
bugfix
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
vinistock
approved these changes
Mar 7, 2025
Merge activity
|
### Motivation Fixes grammar for RBS comments: 1. Properly matches comments inside RBS comments so with `#: Integer # some comment` the `# some comment` is properly highlighted as a `comment.line.number-sign.rbs` 2. Do not match preceding Ruby so with `x = 42 #: Integer` the `x = 42` is properly highlighted using the Ruby grammar ### Automated Tests See tests.
graphite-app
bot
force-pushed
the
va-rbs-grammar-fixes
branch
from
306c4cd to
f695a75
Compare
graphite-app
bot
removed
the
graphite-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes grammar for RBS comments:
#: Integer # some commentthe# some commentis properly highlighted as acomment.line.number-sign.rbsx = 42 #: Integerthex = 42is properly highlighted using the Ruby grammarAutomated Tests
See tests.