Allow add-ons to resolve test commands #3351
Merged
+73
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
Graphite App
vinistock
added
the
experimental
Graphite App
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
force-pushed
the
03-24-allow_add-ons_to_resolve_test_commands
branch
from
305b099 to
f1abf24
Compare
vinistock
force-pushed
the
03-24-ignore_non_minitest_or_test_unit_items_for_resolve_command
branch
from
f6a524b to
7c24faf
Compare
alexcrocha
approved these changes
Mar 24, 2025
st0012
reviewed
Mar 24, 2025
Base automatically changed from
03-24-ignore_non_minitest_or_test_unit_items_for_resolve_command
to
main
March 25, 2025 12:29
vinistock
force-pushed
the
03-24-allow_add-ons_to_resolve_test_commands
branch
from
f1abf24 to
b839e72
Compare
egiurleo
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #3177
Add-ons need to be able to both discover test items and resolve the commands needed to execute them. This PR adds support for add-ons to resolve commands.
Implementation
The idea is to have the add-ons only handle test items that were tagged by them, ignoring everything else. In this scenario, we should be able to simply concatenate all responses and avoid conflicts.
Automated Tests
Added tests.