Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage data collection to the test reporter #3360

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

vinistock
Copy link
Member

@vinistock vinistock commented Mar 27, 2025

Motivation

First step for #1800

This PR adds the capability to our test reporter to collect coverage using Ruby's built-in coverage API.

Implementation

The coverage API is pretty convenient. You invoke Coverage.start to begin collecting and then Coverage.result returns the data.

The implementation is essentially just that. The rest is simply transforming the coverage data that comes from the Ruby API into the format that VS Code expects, so that we don't need any handling on the extension side.

Automated Tests

Added a test.

@vinistock vinistock self-assigned this Mar 27, 2025
Copy link
Member Author

vinistock commented Mar 27, 2025


How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vinistock vinistock added the server This pull request should be included in the server gem's release notes label Mar 27, 2025 — with Graphite App
@vinistock vinistock added the enhancement New feature or request label Mar 27, 2025 — with Graphite App
@vinistock vinistock marked this pull request as ready for review March 27, 2025 14:07
@vinistock vinistock requested a review from a team as a code owner March 27, 2025 14:07
@vinistock vinistock force-pushed the 03-26-add_coverage_collection_to_test_reporter branch from d38a720 to 1ddedb7 Compare March 27, 2025 14:10
@vinistock vinistock force-pushed the 03-26-add_coverage_collection_to_test_reporter branch from 1ddedb7 to b525656 Compare March 27, 2025 20:45
@vinistock vinistock changed the base branch from main to graphite-base/3360 March 28, 2025 12:26
@vinistock vinistock force-pushed the 03-26-add_coverage_collection_to_test_reporter branch from b525656 to 47263d5 Compare March 28, 2025 12:26
@vinistock vinistock changed the base branch from graphite-base/3360 to 03-28-upgrade_development_gems March 28, 2025 12:26
@vinistock vinistock force-pushed the 03-28-upgrade_development_gems branch from 583b92f to e2be29a Compare March 28, 2025 12:35
@vinistock vinistock force-pushed the 03-26-add_coverage_collection_to_test_reporter branch from 47263d5 to b932821 Compare March 28, 2025 12:35
@vinistock vinistock force-pushed the 03-28-upgrade_development_gems branch from e2be29a to 7302dbb Compare March 28, 2025 13:09
@vinistock vinistock force-pushed the 03-26-add_coverage_collection_to_test_reporter branch from b932821 to 2b70b00 Compare March 28, 2025 13:09
Base automatically changed from 03-28-upgrade_development_gems to main March 28, 2025 13:36
@vinistock vinistock force-pushed the 03-26-add_coverage_collection_to_test_reporter branch 2 times, most recently from 68bc969 to 16a063e Compare March 28, 2025 14:53
@vinistock vinistock enabled auto-merge (squash) March 28, 2025 14:53
@vinistock vinistock force-pushed the 03-26-add_coverage_collection_to_test_reporter branch from 16a063e to e585dc8 Compare March 28, 2025 15:21
@vinistock vinistock merged commit 3dc1ad7 into main Mar 28, 2025
42 checks passed
@vinistock vinistock deleted the 03-26-add_coverage_collection_to_test_reporter branch March 28, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request server This pull request should be included in the server gem's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants