Add support for updating REST attributes as blocks #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulomarg
force-pushed
the
rest_block_edit_attributes
branch
from
3aeca70 to
00b4788
Compare
lizkenyon
approved these changes
Aug 12, 2024
lib/shopify_api/rest/base.rb
Outdated
| @@ -17,6 +17,7 @@ class Base | |||
| @paths = T.let([], T::Array[T::Hash[Symbol, T.any(T::Array[Symbol], String, Symbol)]]) | |||
| @custom_prefix = T.let(nil, T.nilable(String)) | |||
| @read_only_attributes = T.let([], T.nilable(T::Array[Symbol])) | |||
| @block_update_attributes = T.let([], T::Array[Symbol]) | |||
There was a problem hiding this comment.
nit: This kinda reads like, this blocks updates to this attribute.
But I don't have any better suggestions. So 🤷
There was a problem hiding this comment.
We could name this update_attributes_as_block, or maybe atomic_attributes?
paulomarg
force-pushed
the
rest_block_edit_attributes
branch
from
00b4788 to
0c432ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1287
As pointed out in the issue, there are certain REST hash fields that need to be sent to the server as a whole, regardless of whether their keys are different or not.
To not break other resources, this is being added as an explicit configuration, so that we can enable it if there are other scenarios in which this happens.
How has this been tested?
Unit tests that simulate the actual requests.
Checklist: