-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Add support for client credentials grant #1362
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91bde9d
to
59bb68c
Compare
lizkenyon
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! ⭐
rezaansyed
reviewed
Feb 20, 2025
rezaansyed
reviewed
Feb 20, 2025
rezaansyed
reviewed
Feb 20, 2025
59bb68c
to
a51dfaa
Compare
RyanDJLee
reviewed
Feb 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had some minor comments, but looks great!
rezaansyed
approved these changes
Feb 20, 2025
a51dfaa
to
67d5a0c
Compare
67d5a0c
to
89869ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Resolves https://github.com/Shopify/develop-app-access/issues/622
Similar PR for
shopify-api-js
library: [Feature]: added support client credentials in shopify-api-js shopify-app-js#2053WHAT is this pull request doing?
How has this been tested?
What should the reviewers focus on?
token_exchage
andoauth
flows both usecreate_session
file, see that changes do not affect the current behaviour of the library.ShopifyApi::Auth::Session.from
now supports expiration for both online and offline tokens.Setup Instructions
partners:dev
spin up partners:dev --wait
Tophatting
Video
Instructions
client-creds-tophat-ruby
app is correct. It should be a relative path to your locally clonedshopify-api-ruby
library.Perform Client Credentials Request
, in your appclient_credentials
flow fromshopify-api-ruby
library and then return the response.access_token
, andexpires
keys.Checklist: