Correctly translate constant write nodes' location #396
+8
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not covered in parse tree location tests, but reflected in symbol table tests: when we write `FOO = 1` (or other constant write nodes), the location of `FOO` should just be the name, not the entire assignment. In those cases, we should use `name_loc` instead of `base.location`.
st0012
commented
Jan 6, 2025
| @@ -295,8 +295,6 @@ pipeline_tests( | |||
| "testdata/lsp/completion/self_receiver.rb", | |||
|
|
|||
| # Desugar tests having to do with tree differences; will address later | |||
| "testdata/desugar/constant_error.rb", | |||
| "testdata/desugar/for.rb", | |||
egiurleo
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is not covered in parse tree location tests, but reflected in symbol table tests: when we write
FOO = 1(or other constant write nodes), the location ofFOOshould just be the name, not the entire assignment.In those cases, we should use
name_locinstead ofbase.location.Fixes #342, #391, and some items in #388
Test plan
See included automated tests.