Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update logs in infra monitoring for analytics #6994

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amlannandy
Copy link
Member

@amlannandy amlannandy commented Jan 31, 2025

Summary

Updated existing logs and added some new ones in infra monitoring

Related Issues / PR's

Fixes #6893

Screenshots

NA

Affected Areas and Manually Tested Areas

Infra Monitoring K8s


Important

Enhance logging in Kubernetes infrastructure monitoring for detailed analytics on user interactions.

  • Logging Enhancements:
    • Added detailed logging for user interactions in ClusterDetails.tsx, K8sClustersList.tsx, DaemonSetDetails.tsx, K8sDaemonSetsList.tsx, DeploymentDetails.tsx, K8sDeploymentsList.tsx, JobDetails.tsx, K8sJobsList.tsx, NamespaceDetails.tsx, K8sNamespacesList.tsx, NodeDetails.tsx, K8sNodesList.tsx, PodDetails.tsx, K8sPodLists.tsx, StatefulSetDetails.tsx, K8sStatefulSetsList.tsx, K8sVolumesList.tsx.
    • Logs include page visits, tab changes, filter applications, and pagination changes.
  • Code Structure:
    • Introduced logEvent calls in various event handlers to capture user actions.
    • Updated pagination logic to include logging of page number changes.
  • Miscellaneous:
    • Minor refactoring to ensure consistent logging across different components.

This description was created by Ellipsis for bfa68c0. It will automatically update as commits are pushed.

@amlannandy amlannandy requested a review from YounixM as a code owner January 31, 2025 07:36
@github-actions github-actions bot added the chore label Jan 31, 2025
@amlannandy amlannandy force-pushed the chore/infra-monitoring-analytics branch from bfa68c0 to e12f6f0 Compare January 31, 2025 07:36
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to bfa68c0 in 1 minute and 22 seconds

More details
  • Looked at 1053 lines of code in 18 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/src/container/InfraMonitoringK8s/Volumes/K8sVolumesList.tsx:430
  • Draft comment:
    Ensure consistency in log event naming. Consider using 'Infra Monitoring: K8s volumes list group by changed' for consistency with other similar log events.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The logEvent function is used consistently across the codebase to track user interactions and state changes. However, there is a minor inconsistency in the naming of the log event for the "group by" change in the Volumes list. It should be consistent with other similar log events.

Workflow ID: wflow_GA0OHQn3gpjN8GzH


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product analytics for infra monitoring
1 participant