Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change grid to flex - flower metrics section #7027

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

YounixM
Copy link
Member

@YounixM YounixM commented Feb 5, 2025

Before:
Screenshot 2025-02-05 at 10 14 59 AM

After:
Screenshot 2025-02-05 at 11 37 35


Important

Change metric-page-grid layout from grid to flex in CeleryTaskGraph.style.scss.

  • Layout Change:
    • Change metric-page-grid from grid to flex layout in CeleryTaskGraph.style.scss.
    • Set flex-direction: row for metric-page-grid to align items horizontally.

This description was created by Ellipsis for 66a120f. It will automatically update as commits are pushed.

@github-actions github-actions bot added docs required enhancement New feature or request labels Feb 5, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 66a120f in 36 seconds

More details
  • Looked at 16 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/src/components/CeleryTask/CeleryTaskGraph/CeleryTaskGraph.style.scss:118
  • Draft comment:
    Switching from grid to flex removes the explicit column sizing. Confirm that the layout still meets design requirements across different screen sizes and that spacing/alignment behave as expected.
  • Reason this comment was not posted:
    Marked as duplicate.
2. frontend/src/components/CeleryTask/CeleryTaskGraph/CeleryTaskGraph.style.scss:118
  • Draft comment:
    Switching .metric-page-grid from grid to flex removes explicit column sizing (grid-template-columns) and vertical alignment (align-items: flex-start). Ensure that child elements get the intended widths and alignment—consider using flex properties (e.g., flex-basis) if fixed column ratios are needed.
  • Reason this comment was not posted:
    Comment did not seem useful: The comment starts with 'Ensure that...', which is a red flag according to the rules. It suggests ensuring that child elements get the intended widths and alignment, which is not allowed. The comment is not approved.

Workflow ID: wflow_9Txbi2nLywRwUseT


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@YounixM YounixM merged commit f6b2d5a into main Feb 5, 2025
19 of 21 checks passed
@YounixM YounixM deleted the feat/flower-metrics-grid-flex branch February 5, 2025 06:18
hudsongeovane pushed a commit to hudsongeovane/signoz that referenced this pull request Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs not required enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants