Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Fix typing for dict/dict[Any, Any] SchemaField #9383

Merged

Conversation

kcze
Copy link
Contributor

@kcze kcze commented Jan 31, 2025

Type system complains about this entry as impossible but this code path is possible and without it some blocks are broken (e.g. Step Through Items)

Changes 🏗️

  • Restore case "object" in NodeGenericInputField
  • Update BlockIOKVSubSchema type, so ts type checking doesn't complain

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@kcze kcze requested a review from a team as a code owner January 31, 2025 09:56
@kcze kcze requested review from ntindle, majdyz and Pwuts and removed request for a team and majdyz January 31, 2025 09:56
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Jan 31, 2025
Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit e1e54d9
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/679e040282f2e1000828d4d8

Copy link

deepsource-io bot commented Jan 31, 2025

Here's the code health analysis summary for commits f481de1..e1e54d9. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ Success
❗ 11 occurences introduced
🎯 10 occurences resolved
View Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit e1e54d9
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/679e0402d79c22000955a269

@Pwuts
Copy link
Member

Pwuts commented Jan 31, 2025

So I guess the schema for Step Through Items doesn't adhere to the defined schema type? What's the schema for that block?

@kcze kcze marked this pull request as draft February 1, 2025 09:25
@kcze kcze changed the title fix(frontend): Restore case "object" in NodeGenericInputField fix(platform): Fix schema for dict/dict[Any, Any] SchemaFields Feb 1, 2025
@kcze kcze changed the title fix(platform): Fix schema for dict/dict[Any, Any] SchemaFields fix(platform): Fix schema for dict/dict[Any, Any] SchemaField Feb 1, 2025
@kcze kcze changed the title fix(platform): Fix schema for dict/dict[Any, Any] SchemaField fix(frontend): Fix typing for dict/dict[Any, Any] SchemaField Feb 1, 2025
@kcze kcze marked this pull request as ready for review February 1, 2025 11:25
@kcze kcze added this pull request to the merge queue Feb 1, 2025
Merged via the queue into dev with commit 74b8b45 Feb 1, 2025
25 checks passed
@kcze kcze deleted the kpczerwinski/open-2351-restore-case-object-in-nodegenericinputfield branch February 1, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end size/m
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants