[BUG FIX] [MER-4262] 500 internal server error when accessing assessment settings #5441
+52
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-assessment-settings' into MER-4262-500-Internal-Server-Error-when-accessing-Assessment-Settings-in-Student-Delivery-LTI-Canvas-in-QA
simonchoxx
reviewed
Feb 26, 2025
There was a problem hiding this comment.
I have tested the changes locally. I can enter the view correctly as an Admin.
However, I find that there are some issues when trying to modify some settings as Admin (the liveview crashes).
I think the problem is happening when saving the changes.
I'm not sure if it should be fixed in this PR or in some other PR (maybe it would be good to fix it in this PR as it should not be too expensive).
assessment_settings.mov
|
Good catch, there was an issue related to this view expecting an Author to be loaded into session context. I fixed the issue. |
simonchoxx
deleted the
MER-4262-500-Internal-Server-Error-when-accessing-Assessment-Settings-in-Student-Delivery-LTI-Canvas-in-QA
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eliterate.atlassian.net/browse/MER-4262
Fixes an issue where when logged in as an admin, the assessment settings page throws a 500 error.
The issue was caused by the result user of
Mount.forinSettingsLiveoverwriting thecurrent_userassigns with an Author (when logged in admin account). This was causing some of the UserAuth logic to break.This was originally being worked on as part of MER-4262, but since there is a separate ticket targeted for this specific issue I am submitting this fix for MER-4262 and any additional work done for MER-4262 will be tracked by that Jira ticket and completed with another PR.