Use explicit types #2855
Open
Use explicit types #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefannikolei
force-pushed
the
sn/use_explicit_types
branch
from
95b56d3 to
dfa0188
Compare
|
I had to install libgdiplus for ubuntu-latest. it seems it was changed from ubuntu 22-04 to 24-04 in the last days |
4 tasks
| @@ -470,8 +470,8 @@ private static void ClampImpl<T>(Span<T> span, T min, T max) | |||
| where T : unmanaged | |||
| { | |||
| ref T sRef = ref MemoryMarshal.GetReference(span); | |||
| var vmin = new Vector<T>(min); | |||
| var vmax = new Vector<T>(max); | |||
| Vector<T> vmin = new Vector<T>(min); | |||
There was a problem hiding this comment.
Let's make sure we use target -typed-new expressions where possible.
There was a problem hiding this comment.
ok gonna look into configuring it and then change all places
stefannikolei
force-pushed
the
sn/use_explicit_types
branch
2 times, most recently
from
2fb6d7a to
963166b
Compare
stefannikolei
force-pushed
the
sn/use_explicit_types
branch
from
963166b to
9be1ec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use explicit type instead of var.
Now only this is changed not as in #2803 where some more things were changed and Stylecop was not happy with it