Fixes Equality check of Vertex #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Now the overlap_y.geojson is fixxed. When 4 Elements were remaining the calculation of the intersection yielded an Point with y=-2.999999999 in the JS calculation it was -3. We can use this or could look deeper into the intersection calculation if something can be fixxed there
* Reverted the equal check in vertex
|
Ah yes, I missed that! Well done! |
JimBobSquarePants
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the overlap_y.geojson is fixxed. When 4 Elements were remaining the calculation of the intersection yielded a Point with y=-2.999999999 in the JS calculation it was -3. This is just a following problem seq1 has an inaccuracy. It should be 5.5
It can be debugged by setting an breakpoint on L205 of PolygonCLipper with event queue.count == 4
We can use this or could look deeper into the intersection calculation if something can be fixxed there