Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Breadcrumbs not detecting frontmatter tags for Tag Notes Explicit Edge Builder #588

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Corbanator
Copy link

Fixes issue where Breadcrumbs could not detect tags in the frontmatter when building edges from tag notes. Fixes the issue I was having that I mentioned in #568, although I'm unsure if it fixes the problem the original issue creator was having.

Basically, it seems Obsidian may have updated their API, and frontmatter and body notes now appear in different formats and in different portions of the data, so it is necessary to check both. This also requires standardizing the formatting (whether to include the # in the string), since in frontmatter, Obsidian accepts either and displays them identically, but does not pass them to plugins identically.

I also added proper returning of errors in a couple of spots, since otherwise those return statements will just return undefined.

Fixes issue where Breadcrumbs could not detect tags in the frontmatter
when building edges from tag notes.
@jacobmichels
Copy link

I forked, created a release, and tested these changes for myself with BRAT and can confirm that that they seem to work. My tag notes work now 🚀

@Corbanator
Copy link
Author

I almost forgot, I have a couple of small changes to make before this gets merged that I haven't had a chance to apply properly. I should have them applied tonight. It's just using a preexisting function in the project rather than hand-coding it in a few places.

@Corbanator
Copy link
Author

Done, that was quicker than expected, I thought it had been a few lines, but it was only one.

@SkepticMystic
Copy link
Owner

Thanks for your PR! It looks good, happy to merge once I've got time and the current PR is live

@SkepticMystic SkepticMystic linked an issue Feb 18, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Bug: Tag Notes not creating edges
3 participants