Refactor rules (#77)

* Revert issue where S3CrossAccountTrustRule would accept whitelisted aws accounts * Fix cross-account rules * Refactor * Bump to 0.11.0 * fix canonical ids and services * fix format * remove unused import
Skyscanner · Nov 21, 2019 · 4db9f36 · 4db9f36
1 parent 82d8ed7
commit 4db9f36
Show file tree

Hide file tree

Showing 50 changed files with 321 additions and 463 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,10 +3,11 @@ All notable changes to this project will be documented in this file.
 
 ## [0.11.0] - 2019-11-20
 ### Breaking changes
-- Moved some files from model to rules, renamed rules to match pythonic style
+- Moved some files from model to rules, renamed rules to match pythonic style. Moved tons of classes around
 ### Fixes
 - Fix a regression that caused `S3CrossAccountTrustRule` and `CrossAccountTrustRule` not to alert whenever 
 cross-account permissions are found within the allowed list of aws accounts.
+- `CrossAccountTrustRule` wrongly say that AWS canonical ids and services were a cross-account relationship.
 
 ## [0.10.2] - 2019-11-20
 ### Added

diff --git a/cfripper/rules/CrossAccountTrustRule.py b/cfripper/rules/CrossAccountTrustRule.py
diff --git a/cfripper/rules/FullWildcardPrincipalRule.py b/cfripper/rules/FullWildcardPrincipalRule.py
diff --git a/cfripper/rules/IAMRoleWildcardActionOnPermissionsPolicyRule.py b/cfripper/rules/IAMRoleWildcardActionOnPermissionsPolicyRule.py
diff --git a/cfripper/rules/IAMRoleWildcardActionOnTrustPolicyRule.py b/cfripper/rules/IAMRoleWildcardActionOnTrustPolicyRule.py
diff --git a/cfripper/rules/PartialWildcardPrincipal.py b/cfripper/rules/PartialWildcardPrincipal.py
diff --git a/cfripper/rules/S3BucketPolicyWildcardActionRule.py b/cfripper/rules/S3BucketPolicyWildcardActionRule.py
diff --git a/cfripper/rules/S3BucketPublicReadWriteAclRule.py b/cfripper/rules/S3BucketPublicReadWriteAclRule.py
diff --git a/cfripper/rules/S3CrossAccountTrustRule.py b/cfripper/rules/S3CrossAccountTrustRule.py
diff --git a/cfripper/rules/SQSQueuePolicyNotPrincipalRule.py b/cfripper/rules/SQSQueuePolicyNotPrincipalRule.py
diff --git a/cfripper/rules/SQSQueuePolicyWildcardActionRule.py b/cfripper/rules/SQSQueuePolicyWildcardActionRule.py
diff --git a/cfripper/rules/SecurityGroupIngressOpenToWorld.py b/cfripper/rules/SecurityGroupIngressOpenToWorld.py
diff --git a/cfripper/rules/SecurityGroupMissingEgressRule.py b/cfripper/rules/SecurityGroupMissingEgressRule.py