Skip to content

Commit

Permalink
Fix for add_failure on cross_account (#119)
Browse files Browse the repository at this point in the history
* fix_add_failure_on_cross_Account: fix

* fix_add_failure_on_cross_Account: update version and changelog]gp
  • Loading branch information
oscarbc96 authored Apr 14, 2020
1 parent 0fe56a5 commit 9fb9075
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# Changelog
All notable changes to this project will be documented in this file.

## [0.18.1] - 2020-04-14
### Fixed
- `CrossAccountCheckingRule` calling `add_failure_to_result` on `UNDEFINED_` was missing context variable.

## [0.18.0] - 2020-04-07
### Improvements
- `EC2SecurityGroupIngressOpenToWorldRule`, `EC2SecurityGroupMissingEgressRule` and `EC2SecurityGroupOpenToWorldRule` include support for filters.
Expand Down
2 changes: 1 addition & 1 deletion cfripper/__version__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
VERSION = (0, 18, 0)
VERSION = (0, 18, 1)

__version__ = ".".join(map(str, VERSION))
1 change: 1 addition & 0 deletions cfripper/rules/cross_account_trust.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ def _do_statement_check(
self.REASON.format(logical_id, principal),
rule_mode=RuleMode.DEBUG,
resource_ids={logical_id},
context=filters_available_context,
)
else:
self.add_failure_to_result(
Expand Down

0 comments on commit 9fb9075

Please sign in to comment.