clone subcommand
#10
clone subcommand
#10
Conversation
cmd/clone/clone.go
Outdated
| } | ||
|
|
||
| c.Printf("Creating branch %s in %s/%s\n", dir.Name, parentPath, repo.RepoName) | ||
| err = exec.Execute(c, workingCopyPath, "git", "checkout", "-b", dir.Name) |
There was a problem hiding this comment.
We should use go-git in the medium term; git is used for parity and ease of testing (using same infra as the testing for execution of gh)
There was a problem hiding this comment.
Raised #13 to track explicitly
rnorth
changed the title
cloneturbolift clone
So that future refactoring away from using CLI binaries is easier.
| dir, _ := os.Getwd() | ||
| dirBasename := path.Base(dir) | ||
|
|
||
| file, err := os.Open("repos.txt") |
There was a problem hiding this comment.
For this I suggest something a bit more structured, like yaml.
It would then be trivial to unmarshall it, instead of the scanner and parsing
There was a problem hiding this comment.
I think this is something I'd like to push back on; having it be text based makes it really easy to generate from a variety of tools.
My worry with using a structured file format for this list is that it'd force people to write a program or do some clever text munging to generate the input.
Perhaps an option to consider later might be to have YAML input in addition, depending on whether a repos.yaml or repos.txt file is present.
For what it's worth, I'd consider the entire campaign directory to be its own kind of structured format: we have a file which just contains a list of repos and a file which just contains the PR title/description in markdown format. Both of those could be combined into a single structured file, but I think that having them separated optimizes for each of input/editing.
Co-authored-by: Sebastien Le Digabel <[email protected]>
|
Thanks @sledigabel |
turbolift cloneusingghandgit. Not using git worktrees for simplicity (the space saving probably isn't worth it, especially at this stage).Resolves #2