Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commit subcommand #17

Merged
merged 2 commits into from
Apr 23, 2021
Merged

commit subcommand #17

merged 2 commits into from
Apr 23, 2021

Conversation

rnorth
Copy link
Collaborator

@rnorth rnorth commented Apr 12, 2021 •
edited
Loading

Resolves #3

@rnorth rnorth changed the title DRAFT implementation of commit - builds upon #10 Draft implementation of commit - BUILDS UPON #10 Apr 12, 2021
@rnorth rnorth force-pushed the commit branch 3 times, most recently from 101813c to 6ba1326 Compare April 16, 2021 11:03
@rnorth rnorth changed the title Draft implementation of commit - BUILDS UPON #10 Draft implementation of commit - BUILDS UPON #16 Apr 16, 2021
@rnorth rnorth added the feature label Apr 16, 2021
@rnorth rnorth changed the title Draft implementation of commit - BUILDS UPON #16 commit subcommand - BUILDS UPON #16 Apr 19, 2021
@rnorth rnorth changed the title commit subcommand - BUILDS UPON #16 commit subcommand Apr 22, 2021
@rnorth rnorth marked this pull request as ready for review April 22, 2021 08:49
sledigabel
sledigabel approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@sledigabel sledigabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. implements commit

sledigabel
sledigabel reviewed Apr 23, 2021
View reviewed changes
internal/git/git.go
@@ -18,6 +22,30 @@ func (r *RealGit) Checkout(output io.Writer, workingDir string, branchName strin
return execInstance.Execute(output, workingDir, "git", "checkout", "-b", branchName)
}

func (r *RealGit) Commit(output io.Writer, workingDir string, message string) error {
return execInstance.Execute(output, workingDir, "git", "commit", "--all", "--message", message)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's typically where #13 would make it a bit nicer

@rnorth
Copy link
Collaborator Author

rnorth commented Apr 23, 2021

Thanks @sledigabel

@rnorth rnorth merged commit a61b538 into main Apr 23, 2021
@rnorth rnorth deleted the commit branch April 23, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sledigabel sledigabel sledigabel approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement turbolift commit
2 participants
@rnorth @sledigabel