- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the install.sh script a lot, added the minor alsa include fix. #219
Conversation
The alsa library is impossible to fix without this repo adding the:
Because the compile step pulls the current state of the repo. @Slackadays |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 47.25% 48.69% +1.44%
==========================================
Files 48 53 +5
Lines 3028 3768 +740
==========================================
+ Hits 1431 1835 +404
- Misses 1597 1933 +336 ☔ View full report in Codecov by Sentry. |
Also, the links are still not working (at least as they are written in the installer script) @Slackadays |
I'm thinking we should just can the nightly links because it's not guaranteed that a nightly build will work, instead using the release links instead which never expire. Do you mind making that change so we don't need to worry about nightlies anymore? |
I made a separate pull request with only one commit from an organization called synchrono-org. @Slackadays |
…. If not found it (should) just not use it.
Thank you for helping fix this monster of an install script! |
Sure! I'm invested at this point. Does this CI cost you anything? I don't want to run up a bill on you. @Slackadays |
I can get the libs into /usr/local/lib, cb into /usr/local/bin, but they are not properly linked. I changed the CMakeLists.txt to not require ALSA, but instead if NO_ALSA then check for ALSA, and if it doesn't exist, just don't set USE_ALSA. That might have some weird CMake side effects, but the build was failing every time before because of that. In a machine without alsa, if you try to include it, it will fail, so thats what the guards are for. All tested platforms can be "installed", but the executable fails at runtime for those platforms. x86_64 sometimes shows up in $(uname -m) as amd64, so adding amd64 solved some problems. Overall net zero attempt, possibly negative, but if its a problem with the CI configuration, then it might work on more systems now. Hopefully this gives some insight for what the problems may be. |
I changed the ordering of the install script to try the package manager, download, and cmake compile (I think) every platform. Also that tiny alsa #include that breaks every build on a platform with no alsa.