Change log directory in docker-compose #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipitsine
reviewed
Feb 25, 2024
| - "./softether_securitylog:/root/security_log" | ||
| - "./softether_log:/usr/local/bin/server_log" | ||
| - "./softether_packetlog:/usr/local/bin/packet_log" | ||
| - "./softether_securitylog:/usr/local/bin/security_log" |
There was a problem hiding this comment.
are those log folders good to keep in /usr/loca/bin ?
There was a problem hiding this comment.
As this is the default of vpnserver i just did not want to mess around with it but for sure they should go to /var/log.
There was a problem hiding this comment.
Is there any way to alter this right on startup or would it make sense to built this right into vpnserver?
There was a problem hiding this comment.
it might be changed during build
These directories can be changed at compile-time by specifying via CMake variables.
* `SE_PIDDIR` - PID directory
* `SE_LOGDIR` - root log directory
* `SE_DBDIR` - config files and variable state directory
|
btw, I see that "docker/xxx" actions are not the most recent available. (while this is not related to current PR) |
|
The README.md file should also be changed accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.