Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix english strings consistency #8881

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

afmenez
Copy link
Contributor

@afmenez afmenez commented Mar 14, 2025

Description

Some terms were used inconsistently.

@afmenez afmenez force-pushed the fix_english_consistency branch 3 times, most recently from 6d2058a to 26c7bc5 Compare March 14, 2025 14:57
@afmenez afmenez force-pushed the fix_english_consistency branch 8 times, most recently from 6a00e45 to 2d08a85 Compare March 18, 2025 12:59
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @afmenez,
Thank you for working on cleaning up the misspellings.
Would you mind combining all the related changes into a single PR instead of opening multiple ones?
Also, it's recommended to make and test the changes locally, and then push all commits all together in one go to the PR.
Instead changing a string then push a commit.
It is because that the CI/CD pipeline runs jobs for every commit you push, which can hog a lot of computational resources.
You’re welcome to make as many commits as needed—just pushing them together

@afmenez afmenez force-pushed the fix_english_consistency branch from 2d08a85 to fa42372 Compare March 22, 2025 15:23
@afmenez
Copy link
Contributor Author

afmenez commented Mar 22, 2025

Hello @SoftFever,
I didn't open all these MRs at once, they were opened on different days along the last weeks. They are taking a long time to get in, so they accumulate.
And that's also why they break the builds, other merges enter first and cause conflicts, and sometimes they break when I fix the merge issues.

@afmenez afmenez force-pushed the fix_english_consistency branch from fa42372 to 794ee40 Compare March 24, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants