Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add K8s Recommended Labels to Pods #574

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add K8s Recommended Labels to Pods #574

wants to merge 2 commits into from
+6 −1

Conversation

wyattfry
Copy link

@wyattfry wyattfry commented Oct 29, 2024 •
edited
Loading

Please ensure your pull request adheres to the following guidelines:

  • explain your motives to contribute this change: what problem you are trying to fix, what improvement you are trying to make
  • Document your Changes in the CHANGELOG.md file of the respected chart as well as the Chart.yaml

This PR adds the Kubernetes-recommended labels "app.kubernetes.io/version" and "app.kubernetes.io/name" to the Pod template.

https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels

@wyattfry
Copy link
Author

wyattfry commented Nov 8, 2024

@carminevassallo @jCOTINEAU Could I please have a review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carminevassallo carminevassallo Awaiting requested review from carminevassallo

At least 1 approving review is required to merge this pull request.

Assignees

@carminevassallo carminevassallo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wyattfry @carminevassallo