Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONAR-24632 Fixes GCP release tasks #640

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Conversation

davividal
Copy link
Collaborator

@davividal davividal commented Mar 14, 2025

SONAR-24632

Part of SONAR-24631

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Fixes GCP release tasks SONAR-24632 Fixes GCP release tasks Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes GCP release tasks as part of SONAR-24631 by updating task trigger conditions and removing a skip rule.

  • Removed the skip condition from the build task template.
  • Updated the only_if conditions to include a changesInclude check when the branch is "master".
  • Applied similar condition modifications across build and verification tasks.
Comments suppressed due to low confidence (2)

.cirrus/tasks_gcp_marketplace.yml:3

  • The removal of the skip condition may allow the task to run even when no relevant changes are present. Please confirm that this change in behavior is intentional.
-  skip: "!changesInclude('charts/sonarqube-dce/*', 'charts/sonarqube-dce/**/*', 'google-cloud-marketplace-k8s-app/*', 'google-cloud-marketplace-k8s-app/**/*', 'tests/unity-compatibility-test/sonarqube-dce/*', '.cirrus/*.sh', '.cirrus/tasks{_sonarqube_dce,_templates,_gcp_marketplace,}.yml', '.cirrus/tasks.star', '.cirrus.star')"

.cirrus/tasks_gcp_marketplace.yml:22

  • Ensure that the newly added changesInclude condition is consistently applied across all tasks requiring deployment triggers to avoid unexpected behavior.
+  only_if: $TRIGGER == "PUSH_STAGING_DEPLOYER" || $TRIGGER == "PUSH_PROD_DEPLOYER" || ($BRANCH == "master" && changesInclude('charts/sonarqube-dce/*', 'charts/sonarqube-dce/**/*', 'google-cloud-marketplace-k8s-app/*', 'google-cloud-marketplace-k8s-app/**/*', 'tests/unity-compatibility-test/sonarqube-dce/*', '.cirrus/*.sh', '.cirrus/tasks{_sonarqube_dce,_templates,_gcp_marketplace,}.yml', '.cirrus/tasks.star', '.cirrus.star'))
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@carminevassallo
Copy link
Collaborator

Could you please copy the description from SONAR-24631 in the new ticket SONAR-24632? Otherwise, it won't be immediate to get context afterwards.

@carminevassallo carminevassallo merged commit 7d0835a into master Mar 18, 2025
26 checks passed
@carminevassallo carminevassallo deleted the dkv/fixes_gcp_release branch March 18, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants