SONARJAVA-5147 FP S1905 when the type cast expression is used to call "getClass()" #5013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alban-auzeill
force-pushed
the
alban/SONARJAVA-5147
branch
from
e387b20 to
4c29038
Compare
|
dorian-burihabwa-sonarsource
requested changes
Feb 11, 2025
There was a problem hiding this comment.
Thanks for adding the new cases with ambiguous .getClass references. Is there a case where the rules is supposed to raise an issue with a .getClass() call? I cannot see any example in this sample
Comment on lines
+95
to
+98
| Tree parent = typeCastTree.parent(); | ||
| while (parent.is(Tree.Kind.PARENTHESIZED_EXPRESSION)) { | ||
| parent = parent.parent(); | ||
| } |
There was a problem hiding this comment.
Can we replace this skipParentheses?
Comment on lines
+100
to
+101
| "getClass".equals(memberSelect.identifier().name()) && | ||
| memberSelect.parent() instanceof MethodInvocationTree methodInvocation && |
There was a problem hiding this comment.
What is most efficient here? To check that the right-hand side of the member select is part of a method invocation first or to match the name?
| @@ -81,9 +83,25 @@ private boolean isUnnecessaryCast(TypeCastTree typeCastTree) { | |||
| Tree parentTree = skipParentheses(typeCastTree.parent()); | |||
| return !parentTree.is(Tree.Kind.ARGUMENTS); | |||
| } | |||
| if (isMethodInvocationReceiverOfGetClass(typeCastTree)) { | |||
| // java.lang.Object#getClass() is a very specific method declared to return Class<?> but in fact | |||
| // returns Class<? extends (receiver type)> at compile time. To prevent false-positive, we ignore this case. | |||
There was a problem hiding this comment.
Suggested change
| // returns Class<? extends (receiver type)> at compile time. To prevent false-positive, we ignore this case. | |
| // returns Class<? extends (receiver type)> at compile time. To prevent false-positives, we ignore this case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARJAVA-5147