Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native SC.MEB #296

Merged
merged 1 commit into from
May 27, 2024
Merged

Native SC.MEB #296

merged 1 commit into from
May 27, 2024

Conversation

shdam
Copy link
Contributor

@shdam shdam commented May 27, 2024

  • I created a default config, but there aren't really any parameters that they modify, so I only included n_pcs and n_genes.

  • The method only works for Visium and ST, it seems, but I made it such that it defaults to ST if the technology is something else, just to let it give it a go.

Closes #278

@shdam shdam requested review from peicai and Jieran-S May 27, 2024 11:49
@Jieran-S
Copy link
Member

Jieran-S commented May 27, 2024

Looks good!

Though given their find_neighbor function, I would say it doesn't make sense to apply this method to imaging-based datasets. If we have time (and energy), we can make a specific offset case for each type of NGS-based technologies (SlideSeq, Visium HD, StereoSeq, ST and Visium).

This also applies to BayesSpace and GraphST. Maybe we can create an issue on this matter and move on to merge this PR.

@shdam
Copy link
Contributor Author

shdam commented May 27, 2024

Good idea. Alternatively, we can find a better neighborhood function. In any case, this method hasn't had a github update in 3 years, so it probably isn't worth spending too much time on.

@Jieran-S
Copy link
Member

Agree...Also if we find a better neighborhood function, it will come back to the question of whether this is still the same method. I think it's important to keep the "native-ness" of the methods implemented.

Issue created: #300

@shdam shdam merged commit cabeeee into native May 27, 2024
@niklasmueboe niklasmueboe deleted the native_scmeb branch February 14, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants