-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement config
feature
#47
Draft
SpriteOvO
wants to merge
4
commits into
main-dev
Choose a base branch
from
config
base: main-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
a2b7cbe
to
71b4fd2
Compare
38cf870
to
62d2abf
Compare
03da466
to
0c4d130
Compare
There's still a lot of work to be done on this, and I'd like to delay it to |
96fa2e1
to
8f46ec1
Compare
7599a65
to
214f40b
Compare
308dfed
to
5c67a97
Compare
0964d50
to
813edaf
Compare
67d2ce1
to
7b08355
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an early implementation of #25 in progress. It is currently very incomplete, just for previewing its API and approach.
Note to self: Remember to change the base branch to
main
ormain-dev
before merging.We mainly introduced a new trait:
then we implement it for built-in sinks and formatters like:
Of course, users can implement this trait for their own sinks and formatters.
With the power of
erased-serde
, we can cast thetype Params
to adyn erased_serde::Deserializer
to be used later. (Checkconfig/registry.rs
)When we deserializing a sink or formatter, we will first read the
name
field, then look it up from the registry, if found, deserializing the rest of the fields using the erased storedDeserializer
. (Checkconfig/parse.rs
)This whole deserialization process will be very hidden to users!
trait Configurable
and.register_xxx()
is the only thing they need to care about if they have their own sink / formatter.