Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix online optimize table fail due to physical partition id changed #56511

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

meegoo
Copy link
Contributor

@meegoo meegoo commented Mar 3, 2025

Why I'm doing:

introduced by #50598 which make default physical partition id different from parent partition id.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@meegoo meegoo requested a review from a team as a code owner March 3, 2025 15:31
@mergify mergify bot assigned meegoo Mar 3, 2025
@github-actions github-actions bot added the 3.4 label Mar 3, 2025
@meegoo meegoo force-pushed the fix_online_optimize branch from 391555a to f3dc237 Compare March 3, 2025 16:52
Copy link

sonarqubecloud bot commented Mar 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
8.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link

github-actions bot commented Mar 3, 2025

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Mar 3, 2025

[FE Incremental Coverage Report]

fail : 12 / 23 (52.17%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/transaction/DatabaseTransactionMgr.java 1 10 10.00% [1396, 1397, 1400, 1401, 1405, 1406, 1434, 1435, 1436]
🔵 com/starrocks/alter/OnlineOptimizeJobV2.java 10 12 83.33% [310, 313]
🔵 com/starrocks/catalog/OlapTable.java 1 1 100.00% []

Copy link

github-actions bot commented Mar 3, 2025

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant