Update error handling for Apollo 4

src/components/forms/GSForm.jsx

@@ -2,7 +2,6 @@ import PropTypes from "prop-types";
 import React from "react";
 import Form from "react-formal";
 import { StyleSheet, css } from "aphrodite";
-import { GraphQLRequestError } from "../../network/errors";
 import { log } from "../../lib";
 import withMuiTheme from "../../containers/hoc/withMuiTheme";
 
@@ -41,9 +40,7 @@ class GSForm extends React.Component {
   }
 
   handleFormError(err) {
-    if (err instanceof GraphQLRequestError) {
-      this.setState({ globalErrorMessage: err.message });
-    } else if (err.message) {
+    if (err.message) {
       this.setState({ globalErrorMessage: err.message });
     } else {
       log.error(err);

src/containers/AssignmentTexterContact.jsx

@@ -141,29 +141,32 @@ export class AssignmentTexterContact extends React.Component {
   };
 
   handleSendMessageError = e => {
-    // NOTE: status codes don't currently work so all errors will appear
-    // as "Something went wrong" keeping this code in here because
-    // we want to replace status codes with Apollo 2 error codes.
-    if (e.status === 402) {
-      this.goBackToTodos();
-    } else if (e.status === 400) {
-      const newState = {
-        snackbarError: e.message
-      };
-
-      if (e.message === "Your assignment has changed") {
-        newState.snackbarActionTitle = "Back to todos";
-        newState.snackbarOnClick = this.goBackToTodos;
-        this.setState(newState);
-      } else {
-        // opt out or send message Error
-        this.setState({
-          disabled: true,
-          disabledText: e.message
-        });
-        this.skipContact();
-      }
-    } else {
+    const error_code = e.graphQLErrors[0].code;
+    if (error_code === 'SENDERR_ASSIGNMENTCHANGED') {
+      this.setState({
+        snackbarError: e.message,
+        snackbarActionTitle: "Back to todos",
+        snackbarOnClick: this.goBackToTodos,
+      });
+    }
+    else if (error_code === 'SENDERR_OPTEDOUT') {
+      this.setState({
+        disabled: true,
+        disabledText: e.message,
+        snackbarError: e.message,
+      });
+      this.handleEditStatus('closed', false);
+      this.skipContact();
+    }
+    else if (error_code === 'SENDERR_OFFHOURS') {
+      this.setState({
+        disabled: true,
+        disabledText: e.message,
+        snackbarError: e.message,
+      });
+      this.skipContact();
+    }
+    else {
       console.error(e);
       this.setState({
         disabled: true,

src/server/api/errors.js

@@ -3,7 +3,11 @@ import { r, cacheableData } from "../models";
 
 export function authRequired(user) {
   if (!user) {
-    throw new GraphQLError("You must login to access that resource.");
+    throw new GraphQLError("You must login to access that resource.", {
+      extensions: {
+        code: 'UNAUTHENTICATED',
+      },
+    });
   }
 }
 
@@ -27,11 +31,11 @@ export async function accessRequired(
     role
   );
   if (!hasRole) {
-    const error = new GraphQLError(
-      "You are not authorized to access that resource."
-    );
-    error.code = "UNAUTHORIZED";
-    throw error;
+    throw new GraphQLError("You are not authorized to access that resource.", {
+      extensions: {
+        code: 'UNAUTHORIZED',
+      },
+    });
   }
 }
 
@@ -73,11 +77,11 @@ export async function assignmentRequiredOrAdminRole(
     roleRequired
   );
   if (!hasPermission) {
-    const error = new GraphQLError(
-      "You are not authorized to access that resource."
-    );
-    error.code = "UNAUTHORIZED";
-    throw error;
+    throw new GraphQLError("You are not authorized to access that resource.", {
+      extensions: {
+        code: 'UNAUTHORIZED',
+      },
+    });
   }
   return userHasAssignment || true;
 }

src/server/api/mutations/joinOrganization.js

@@ -6,9 +6,11 @@ import { getConfig } from "../lib/config";
 import telemetry from "../../telemetry";
 
 const INVALID_JOIN = () => {
-  const error = new GraphQLError("Invalid join request");
-  error.code = "INVALID_JOIN";
-  return error;
+  return new GraphQLError("Invalid join request", {
+    extensions: {
+      code: 'INVALID_JOIN',
+    },
+  });
 };
 
 // eslint-disable-next-line import/prefer-default-export
@@ -43,11 +45,11 @@ export const joinOrganization = async (
           r.knex("assignment").where("campaign_id", campaignId)
         );
         if (campaignTexterCount >= maxTextersPerCampaign) {
-          const error = new GraphQLError(
-            "Sorry, this campaign has too many texters already"
-          );
-          error.code = "FAILEDJOIN_TOOMANYTEXTERS";
-          throw error;
+          throw new GraphQLError("Sorry, this campaign has too many texters already.", {
+            extensions: {
+              code: 'FAILEDJOIN_TOOMANYTEXTERS',
+            },
+          });
         }
       }
     } else {

src/server/api/mutations/sendMessage.js

@@ -16,8 +16,11 @@ const JOBS_SAME_PROCESS = !!(
 );
 
 const newError = (message, code, details = {}) => {
-  const err = new GraphQLError(message);
-  err.code = code;
+  const err = new GraphQLError(message, {
+    extensions: {
+      code: code,
+    },
+  });
   if (process.env.DEBUGGING_EMAILS) {
     sendEmail({
       to: process.env.DEBUGGING_EMAILS.split(","),

src/server/api/schema.js

@@ -537,12 +537,7 @@ const rootMutations = {
         .limit(1);
 
       if (!lastMessage) {
-        const errorStatusAndMessage = {
-          status: 400,
-          message:
-            "Cannot fake a reply to a contact that has no existing thread yet"
-        };
-        throw new GraphQLError(errorStatusAndMessage);
+        throw new GraphQLError("Cannot fake a reply to a contact that has no existing thread yet");
       }
 
       const userNumber = lastMessage.user_number;
@@ -1455,20 +1450,23 @@ const rootMutations = {
         join_token: joinToken,
       })
       .first();
-      const INVALID_REASSIGN = () => {
-        const error = new GraphQLError("Invalid reassign request - organization not found");
-        error.code = "INVALID_REASSIGN";
-        return error;
-      };
       if (!campaign) {
-        throw INVALID_REASSIGN();
+        throw new GraphQLError("Invalid reassign request - campaign not found", {
+          extensions: {
+            code: 'INVALID_REASSIGN',
+          },
+        });
       }
       const organization = await cacheableData.organization.load(
         campaign.organization_id
       );
       if (!organization) {
-        throw INVALID_REASSIGN();
-      }      
+        throw new GraphQLError("Invalid reassign request - organization not found", {
+          extensions: {
+            code: 'INVALID_REASSIGN',
+          },
+        });
+      }
       const maxContacts = getConfig("MAX_REPLIES_PER_TEXTER", organization) ?? 200;
       let d = new Date();
       d.setHours(d.getHours() - 1);

src/server/index.js

@@ -70,21 +70,25 @@ const server = new ApolloServer({
   resolvers,
   introspection: true,
   plugins: [ApolloServerPluginDrainHttpServer({ httpServer })],
-  formatError: error => {
+  formatError: (formattedError, error) => {
+    log.error({
+      // TODO: request is no longer available in formatError, figure out
+      // another way to do this.
+      // userId: request.user && request.user.id,
+      code: error?.extensions?.code ?? 'INTERNAL_SERVER_ERROR',
+      error: formattedError,
+      msg: "GraphQL error"
+    });
+
     if (process.env.SHOW_SERVER_ERROR || process.env.DEBUG) {
-      if (error instanceof GraphQLError) {
-        return error;
-      }
-      return new GraphQLError(error.message);
+      return formattedError;
     }
 
-    return new GraphQLError(
-      error &&
-      error.originalError &&
-      error.originalError.code === "UNAUTHORIZED"
-        ? "UNAUTHORIZED"
-        : "Internal server error"
-    );
+    // Strip out stacktrace and other potentially sensative details.
+    return {
+      message: formattedError.message,
+      code: formattedError?.extensions?.code ?? 'INTERNAL_SERVER_ERROR',
+    };
   }
 });