Update arduino.ino #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Stephen-Arsenault
commented
May 3, 2022
Stephen-Arsenault
commented
- Adding timers for read / write
- Improving serial messaging
rdmark
reviewed
May 5, 2022
| if (currentTime > 10000) { | ||
| currentTime = readAverage; | ||
| } | ||
| readAverage = readAverage == 0 ? currentTime : ((readAverage + currentTime) / 2); |
There was a problem hiding this comment.
Maybe the division here is inefficient? (just guessing)
rdmark
reviewed
May 5, 2022
Arduino Code/arduino.ino
Outdated
Comment on lines
78
to
79
| unsigned int long stopWrite = micros(); | ||
| unsigned int long currentTime = stopWrite - startWrite; |
There was a problem hiding this comment.
Not sure what's common with Ardiuno code, but I always like to declare variables at the top of the function. Not sure if this has a performance implication or not (probably not).
| interrupts(); Serial.println("Test: Write \"1\" then \"0\" and Verify Read"); Serial.flush(); noInterrupts(); fill(1); | ||
| unsigned int long dramTimerStop = micros(); | ||
| unsigned int long dramTimerDuration = dramTimerStop - dramTimerStart; | ||
| interrupts(); Serial.println((String)"Total Test Duration: " + (dramTimerDuration / 1000) + " ms"); Serial.flush(); noInterrupts(); |
There was a problem hiding this comment.
Another example of math that could be slow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.