Fix nested quotes and brackets #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2024 17:52
resolves vuejs/vue-syntax-highlight#220 This commit includes JavaScript expression instead of embedding it in order to maintain context stack and enable nested quotes and brackets without terminating script context too early. This increases compiled syntax cache from 37kB to 170kB but it is still within sane values.
It causes whole attribute name part not being addressable anymore if dynamic parameters are present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #28
This PR includes JavaScript expression instead of embedding it
in order to maintain context stack and enable nested quotes and brackets
without terminating script context too early.
This increases compiled syntax cache from 37kB to 170kB but it is still
within sane values.