Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak vue directive meta scopes #32

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

deathaxe
Copy link
Member

This PR...

  1. replaces HTML like meta.attribute-with-value by dedicated meta.directive.[parameter|modifier|value].vue scope to provide unique names for each part of them.
  2. Removes stacking entity.other and keyword scopes to reduce overall scope name complexity/length.

deathaxe added 2 commits November 21, 2024 20:36
This commit

1. replaces HTML like `meta.attribute-with-value` by dedicated
   `meta.directive.[parameter|modifier|value].vue` scope to provide unique
   names for each part of them.
2. Removes stacking entity.other and keyword scopes to reduce overall scope
   name complexity/length.
Scope vue values `meta.string.vue string.quoted.[double|single].vue`
to avoid mixing html and vue sub scopes too much and because it is an
easy change to make scopes look more clean.
@deathaxe deathaxe merged commit 7ec7638 into main Nov 21, 2024
8 checks passed
@deathaxe deathaxe deleted the fix/tweak-directive-scopes branch November 21, 2024 19:47
@FichteFoll FichteFoll added this to the 5.0.0 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants