Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JSX as default script language #33

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Use JSX as default script language #33

merged 1 commit into from
Nov 22, 2024

Conversation

deathaxe
Copy link
Member

This commit applies JSX as default syntax for <script> tags to avoid users bothering with trying to do so.

Vue supports writing components with JSX syntax and thus it may appear in normal template script tags. As JSX is fully compatible with normal JavaScript syntax let's use JSX as default syntax.

This commit applies JSX as default syntax for `<script>` tags
to avoid users bothering with trying to do so.

Vue supports writing components with JSX syntax and thus it may appear
in normal template script tags. As JSX is fully compatible with normal
JavaScript syntax let's use JSX as default syntax.
@deathaxe deathaxe merged commit 2fdc87f into st4107 Nov 22, 2024
2 checks passed
@deathaxe deathaxe deleted the fix/jsx-support branch November 22, 2024 09:51
@FichteFoll FichteFoll added this to the 4.2.0 milestone Nov 22, 2024
@niksy
Copy link

niksy commented Feb 14, 2025

@deathaxe it seems like this broke default JavaScript syntax snippets support since they’re scoped to source.js. I’ve raised issue in JavaScript syntax repository, but I don’t know where this should be adjusted to work as it did before this change. IMO this should be JS syntax change since it should also cover TypeScript and TSX.

@FichteFoll
Copy link
Member

Fixed upstream: sublimehq/Packages#4158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants