Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix when prawn suit drilling doesn't save raw materials globally #2301

Conversation

Buivol16
Copy link

@Buivol16 Buivol16 commented Mar 9, 2025

Fix issue link: #2278

@Buivol16
Copy link
Author

Buivol16 commented Mar 9, 2025

This is a cover for a previous PR.

Copy link
Contributor

@OhmV-IR OhmV-IR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor cleanup things

/// </summary>
public sealed partial class ResourceTracker_OnPickedUp_Patch : NitroxPatch, IDynamicPatch
{
public static readonly MethodInfo TARGET_METHOD = Reflect.Method((ResourceTracker d) => d.OnPickedUp(default));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be made private

@@ -0,0 +1,26 @@
using System.Reflection;
using NitroxClient.GameLogic;
using NitroxModel.Core;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run clean and sort usings, Ctrl R+G in VS2022, in this case remove the using NitroxModel.Core line

@Buivol16 Buivol16 force-pushed the prawn-suit-drilling-doesn't-save-raw-materials-globally branch from 76b85e9 to 07ea6a9 Compare March 9, 2025 20:15
@Buivol16
Copy link
Author

Buivol16 commented Mar 9, 2025

Minor cleanup things

fix PR

@Jannify Jannify linked an issue Mar 9, 2025 that may be closed by this pull request
@Coding-Hen Coding-Hen closed this Mar 9, 2025
@Coding-Hen
Copy link
Collaborator

Thank you for the PR, I am going to close it in favour of #2304 as it is more complete, please don't let this put you off though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prawn suit drilling doesn't save raw materials globally
3 participants