STYLE: Replace bitwise with logical _and_ (&&) on bool retdc variables

Encountered by Matt McCormick.
SuperElastix · Jun 21, 2023 · c74c68b · c74c68b
1 parent 97fec1f
commit c74c68b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/Core/ComponentBaseClasses/elxResamplerBase.hxx b/Core/ComponentBaseClasses/elxResamplerBase.hxx
@@ -388,7 +388,7 @@ ResamplerBase<TElastix>::WriteResultImage(OutputImageType *   image,
   DirectionType originalDirection;
   bool          retdc = this->GetElastix()->GetOriginalFixedImageDirection(originalDirection);
   infoChanger->SetOutputDirection(originalDirection);
-  infoChanger->SetChangeDirection(retdc & !this->GetElastix()->GetUseDirectionCosines());
+  infoChanger->SetChangeDirection(retdc && !this->GetElastix()->GetUseDirectionCosines());
   infoChanger->SetInput(image);
 
   /** Do the writing. */
@@ -476,7 +476,7 @@ ResamplerBase<TElastix>::CreateItkResultImage()
   DirectionType originalDirection;
   bool          retdc = this->GetElastix()->GetOriginalFixedImageDirection(originalDirection);
   infoChanger->SetOutputDirection(originalDirection);
-  infoChanger->SetChangeDirection(retdc & !this->GetElastix()->GetUseDirectionCosines());
+  infoChanger->SetChangeDirection(retdc && !this->GetElastix()->GetUseDirectionCosines());
   infoChanger->SetInput(resampleImageFilter.GetOutput());
 
   /** cast the image to the correct output image Type */

diff --git a/Core/ComponentBaseClasses/elxTransformBase.h b/Core/ComponentBaseClasses/elxTransformBase.h
@@ -360,7 +360,7 @@ class ITK_TEMPLATE_EXPORT TransformBase : public BaseComponentSE<TElastix>
     typename FixedImageType::DirectionType originalDirection;
     const bool                             retdc = this->m_Elastix->GetOriginalFixedImageDirection(originalDirection);
     infoChanger->SetOutputDirection(originalDirection);
-    infoChanger->SetChangeDirection(retdc & !this->m_Elastix->GetUseDirectionCosines());
+    infoChanger->SetChangeDirection(retdc && !this->m_Elastix->GetUseDirectionCosines());
     infoChanger->SetInput(image);
 
     return infoChanger;

diff --git a/Core/ComponentBaseClasses/elxTransformBase.hxx b/Core/ComponentBaseClasses/elxTransformBase.hxx
@@ -1043,7 +1043,7 @@ TransformBase<TElastix>::GenerateDeformationFieldImage() const -> typename Defor
   typename FixedImageType::DirectionType originalDirection;
   bool                                   retdc = this->GetElastix()->GetOriginalFixedImageDirection(originalDirection);
   infoChanger->SetOutputDirection(originalDirection);
-  infoChanger->SetChangeDirection(retdc & !this->GetElastix()->GetUseDirectionCosines());
+  infoChanger->SetChangeDirection(retdc && !this->GetElastix()->GetUseDirectionCosines());
   infoChanger->SetInput(defGenerator->GetOutput());
 
   const Configuration & configuration = Deref(Superclass::GetConfiguration());