Allow only a _raw_ pointer as Deref argument, Deref sampler input and output at the start of GenerateData()
#1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears somewhat risky to allow a smart pointer as `Deref` argument, as the original "smart" lifetime management may then be lost, in some cases. Adjusted `Deref` calls in `AdvancedTransformAdapter` accordingly. Following InsightSoftwareConsortium/ITK#4278 commit InsightSoftwareConsortium/ITK@042d423 "Add `Deref(T *)`, to ease dereferencing a pointer safely"
`Deref` checks that the input and output pointers are not null. It appears more secure to just do that right at the begin of the `GenerateData()` member function of these ImageSamplers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.