Merge pull request #1 from mariusz96/bugfix

Fix bug in path validation
Swimburger · May 21, 2024 · 664bcd2 · 664bcd2
2 parents 4c51348 + 32d2869
commit 664bcd2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/UrlShortener.Data/ShortUrlValidator.cs b/UrlShortener.Data/ShortUrlValidator.cs
@@ -74,6 +74,6 @@ public static bool ValidatePath(string? path, out string[] validationResults)
             validationResultsList.Add("Path can only contain alphanumeric characters, underscores, and dashes.");
 
         validationResults = validationResultsList.ToArray();
-        return validationResultsList.Count > 0;
+        return validationResultsList.Count == 0;
     }
 }
diff --git a/UrlShortener.Forwarder/Program.cs b/UrlShortener.Forwarder/Program.cs
@@ -16,8 +16,8 @@
     ShortUrlRepository shortUrlRepository
 ) =>
 {
-    if(ShortUrlValidator.ValidatePath(path, out _))
-        return Results.BadRequest();
+    if (!ShortUrlValidator.ValidatePath(path, out var validationResults))
+        return Results.BadRequest(validationResults);
 
     var shortUrl = await shortUrlRepository.Get(path);
     if (shortUrl == null || string.IsNullOrEmpty(shortUrl.Destination))