Fix black hole #142
Merged
Fix black hole #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBD Spec Test Vectors Report (tbdex-rs)
❌ Missing Vectors (1)These are test vectors without any test cases.
Automatically generated at: 2024-10-18T19:47:21.564Z |
TBD Spec Test Vectors Report (tbdex-core-kt)
Automatically generated at: 2024-10-18T19:51:52.798Z |
nitro-neal
requested review from
KendallWeihe,
shamilovtim,
diehuxx and
frankhinek
as code owners
| @@ -158,21 +132,13 @@ async function fetchExchangeData( | |||
| pfiDidUri: string, | |||
| bearerDid: BearerDid, | |||
| exchangeId: string | |||
| ): Promise<Message[]> { | |||
| ): Promise<Exchange> { | |||
There was a problem hiding this comment.
nice, the type system works!
KendallWeihe
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.