update ts actions #143
Merged
update ts actions #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBD Spec Test Vectors Report (tbdex-rs)
❌ Missing Vectors (1)These are test vectors without any test cases.
Automatically generated at: 2024-10-22T00:34:25.725Z |
TBD Spec Test Vectors Report (tbdex-core-kt)
Automatically generated at: 2024-10-22T00:39:29.556Z |
|
this ci release will make a new tag so that we can have multiple tags and versions living in the same repo, prefixed by the ts-v. |
nitro-neal
requested review from
KendallWeihe,
shamilovtim,
diehuxx and
frankhinek
as code owners
| "name": "tbdex", | ||
| "name": "@tbdex/sdk", |
There was a problem hiding this comment.
Thoughts on just tbdex? Looks like npm doesn't support @tbdex because the @ is a scope which must be followed by package name, but we could be daring and just do tbdex, right?
KendallWeihe
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Name comment is a non-blocker. I vote tbdex over @tbdex/sdk but I may be missing some context.
Also, something to keep in mind when we run the release, we had an intentional effort when we published the kt maven artifact to align all major+minor versions across implementations, so I think that means v4 major when we go to release, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.