-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use workspace for deps #903
Conversation
🦋 Changeset detectedLatest commit: 0ae5162 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-09-16T12:57:05Z |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #903 +/- ##
=======================================
Coverage 93.44% 93.44%
=======================================
Files 117 117
Lines 33470 33470
Branches 2704 2704
=======================================
Hits 31277 31277
Misses 2154 2154
Partials 39 39
|
Context
When debugging an issue last week we found the @web5/common package was duplicated multiple times in the monorepo by shipping 3 different versions to the other packages, which was both unexpected and made debugging more difficult
Implementation
Use the
workspace
pnpm directive in order to link the local packages rather than the published packages. This links the packages to the same local version and removes the strain of having to manually manage it.