Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handroll Bencoder #187

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

handroll Bencoder #187

wants to merge 3 commits into from

Conversation

mistermoe
Copy link
Member

Had this branch sitting around locally for awhile and just remembered. Original intent was to handroll a Bencoder so we could drop the bittorrent dep we were pulling in because:

  • it wasn't hosted on maven central (requiring downstream consumers to add yet another repository)
  • it introduced a ton of CVEs

looks like @andresuribe87 beat me to it in his most recent PR to update did:dht to reflect the spec text changes we recently made

figured i'd toss this PR up anyway incase we want a more complete Bencoder (though not needed. @andresuribe87 implemented exactly what we needed in order to drop the dep)

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Merging #187 (717ece5) into main (22aa339) will increase coverage by 0.32%.
The diff coverage is 96.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   79.82%   80.15%   +0.32%     
==========================================
  Files          34       35       +1     
  Lines        2042     2086      +44     
  Branches      293      305      +12     
==========================================
+ Hits         1630     1672      +42     
- Misses        279      280       +1     
- Partials      133      134       +1     
Components Coverage Δ
credentials 81.74% <ø> (ø)
crypto 38.07% <ø> (ø)
dids 90.31% <96.36%> (+0.20%) ⬆️
common 80.55% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant