Skip to content

Commit

Permalink
comment-out test which use outdated reference values from the netCDF …
Browse files Browse the repository at this point in the history 
…file
  • Loading branch information
@Alexander-Barth
Alexander-Barth committed Feb 4, 2024
1 parent 64c54d4 commit 9d1bc30
Showing 1 changed file with 15 additions and 10 deletions.
25 changes: 15 additions & 10 deletions test/runtests.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@
# International Association for the Physical Sciences of the Oceans, Working Group 127).
# https://github.com/TEOS-10/GSW-C/blob/95a9caeb128e4793b538b5ded889c83c913584fb/LICENSE


# Tests marked with #need_update use outdated reference values from the netCDF file
# see also:
# https://github.com/TEOS-10/GSW-C/commit/e059acd5a84c432999e803f7fa9e5ace9b16d0ce

using GibbsSeaWater
using Test

Expand Down Expand Up @@ -45,8 +50,8 @@ c = gsw_c_from_sp.(sp,t,p)
end

@testset "Absolute Salinity, Preformed Salinity and Conservative Temperature" begin
@gswtest gsw_sa_from_sp.(sp,p,lon,lat) sa_from_sp
@gswtest gsw_sstar_from_sp.(sp,p,lon,lat) sstar_from_sp
#need_update @gswtest gsw_sa_from_sp.(sp,p,lon,lat) sa_from_sp
#need_update @gswtest gsw_sstar_from_sp.(sp,p,lon,lat) sstar_from_sp
@gswtest gsw_ct_from_t.(sa,t,p) ct_from_t
end

Expand All @@ -57,13 +62,13 @@ sstar = gsw_sstar_from_sa.(sa,p,lon,lat)
pt = gsw_pt_from_ct.(sa,ct)
entropy = gsw_entropy_from_pt.(sa,pt)
@testset "Other conversions between Temperatures, Salinities, Entropy, Pressure and Height" begin
@gswtest gsw_deltasa_from_sp.(sp,p,lon,lat) deltasa_from_sp
#need_update @gswtest gsw_deltasa_from_sp.(sp,p,lon,lat) deltasa_from_sp
@gswtest gsw_sr_from_sp.(sp) sr_from_sp
@gswtest gsw_sp_from_sr.(sr) sp_from_sr
@gswtest gsw_sp_from_sa.(sa,p,lon,lat) sp_from_sa
@gswtest gsw_sstar_from_sa.(sa,p,lon,lat) sstar_from_sa
#need_update @gswtest gsw_sp_from_sa.(sa,p,lon,lat) sp_from_sa
#need_update @gswtest gsw_sstar_from_sa.(sa,p,lon,lat) sstar_from_sa
@gswtest gsw_sa_from_sstar.(sstar,p,lon,lat) sa_from_sstar
@gswtest gsw_sp_from_sstar.(sstar,p,lon,lat) sp_from_sstar
#need_update @gswtest gsw_sp_from_sstar.(sstar,p,lon,lat) sp_from_sstar
@gswtest gsw_pt_from_ct.(sa,ct) pt_from_ct
@gswtest gsw_t_from_ct.(sa,ct,p) t_from_ct
@gswtest gsw_ct_from_pt.(sa,pt) ct_from_pt
Expand All @@ -88,16 +93,16 @@ end
@gswtest gsw_alpha_on_beta.(sa,ct,p) alpha_on_beta
@gswtest gsw_specvol_alpha_beta.(sa,ct,p) v_vab alpha_vab beta_vab
@gswtest gsw_specvol_first_derivatives.(sa,ct,p) v_sa v_ct v_p
@gswtest gsw_specvol_second_derivatives.(sa,ct,p) v_sa_sa v_sa_ct v_ct_ct v_sa_p v_ct_p
#need_update @gswtest gsw_specvol_second_derivatives.(sa,ct,p) v_sa_sa v_sa_ct v_ct_ct v_sa_p v_ct_p
@gswtest gsw_specvol_first_derivatives_wrt_enthalpy.(sa,ct,p) v_sa_wrt_h v_h
@gswtest gsw_specvol_second_derivatives_wrt_enthalpy.(sa,ct,p) v_sa_sa_wrt_h v_sa_h v_h_h
#need_update @gswtest gsw_specvol_second_derivatives_wrt_enthalpy.(sa,ct,p) v_sa_sa_wrt_h v_sa_h v_h_h
@gswtest gsw_specvol_anom_standard.(sa,ct,p) specvol_anom_standard
@gswtest gsw_rho.(sa,ct,p) rho
@gswtest gsw_rho_alpha_beta.(sa,ct,p) rho_rab alpha_rab beta_rab
@gswtest gsw_rho_first_derivatives.(sa,ct,p) rho_sa rho_ct rho_p
@gswtest gsw_rho_second_derivatives.(sa,ct,p) rho_sa_sa rho_sa_ct rho_ct_ct rho_sa_p rho_ct_p
#need_update @gswtest gsw_rho_second_derivatives.(sa,ct,p) rho_sa_sa rho_sa_ct rho_ct_ct rho_sa_p rho_ct_p
@gswtest gsw_rho_first_derivatives_wrt_enthalpy.(sa,ct,p) rho_sa_wrt_h rho_h
@gswtest gsw_rho_second_derivatives_wrt_enthalpy.(sa,ct,p) rho_sa_sa_wrt_h rho_sa_h rho_h_h
#need_update @gswtest gsw_rho_second_derivatives_wrt_enthalpy.(sa,ct,p) rho_sa_sa_wrt_h rho_sa_h rho_h_h
#=
@gswtest gsw_sigma0.(sa,ct), value,sigma0);
@gswtest gsw_sigma1.(sa,ct), value,sigma1);
Expand Down

4 comments on commit 9d1bc30

@Alexander-Barth
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator release

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error while trying to register: Action not recognized: release

@Alexander-Barth
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/100313

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.1.3 -m "<description of version>" 9d1bc307c30386db7cb229f4ae6c21d9173e69b2
git push origin v0.1.3

Please sign in to comment.