Fill the ReferencedAssemblyNames Property for all loaded Assemblies #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made-by-karl
force-pushed
the
referencedAssemblyNames
branch
from
d9bf4cc to
fbdec12
Compare
Fixes issue TNG#311 Signed-off-by: Karl Rhenius <[email protected]>
made-by-karl
force-pushed
the
referencedAssemblyNames
branch
from
fbdec12 to
7bb008e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
=======================================
Coverage 65.65% 65.65%
=======================================
Files 255 255
Lines 23032 23034 +2
Branches 1962 1961 -1
=======================================
+ Hits 15121 15124 +3
+ Misses 7366 7365 -1
Partials 545 545 ☔ View full report in Codecov by Sentry. |
|
Hi @made-by-karl, thank you for your PR. Could you fix the code formatting? I've already created another PR that will fix the issue with the windows build |
fixes code formatting Signed-off-by: Karl Rhenius <[email protected]>
|
LGTM, somehow the formatting got broken again. I will reformat this and merge it after the current prerelease version has been released. |
alexanderlinne
changed the title
alexanderlinne
changed the title
Signed-off-by: Alexander Linne <[email protected]>
fgather
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArchBuilder always adds the names of referenced assemblies from the AssemblyDefinition.MainModule.AssemblyReferences property.
Resolves #311
Signed-off-by: Karl Rhenius [email protected]