Env based deployment #203
Merged
Env based deployment #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
force-pushed
the
better-meili-deployment
branch
from
4016408 to
91f8a59
Compare
CommanderStorm
force-pushed
the
env-based-deployment
branch
2 times, most recently
from
017f6d3 to
4bd62cf
Compare
The reason behind is, that this way Environment based PRs can be realised
removed unnecessary checks for meili existence added an application.yaml, which can be templated in the build
CommanderStorm
force-pushed
the
env-based-deployment
branch
from
2b9c469 to
a5fc316
Compare
|
The goal with this PR is mainly, to insure, that the docs are clear 😉 |
|
I honestly don't have too much knowledge about the deployment detail (thank you for taking care of that!). The Readme is clear to me, but the rest is a bit harder to review. I would be fine if you merge this yourself. The idea of env based deployment is very cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds environment based deployments ⇒ every PR gets its own staging. For example the url for this branch would be https://pr-203.nav.tum.sexy
Just as #202, this is mostly a PR to review the documentation.
It should be merged after that PR
It is in a draft, because there are a few things, I have not yet tested.
Solves one of the bullet points mentioned in #197