Add example of lit query adapter #7715
Conversation
| @@ -0,0 +1,49 @@ | |||
| import type { QueryClient } from '@tanstack/query-core' | |||
There was a problem hiding this comment.
I am not super happy with this solution but I have tried to make it work with lit - Context but I was not able to make it work because of the way it is implemented with the lifecycle.
There was a problem hiding this comment.
I can help with the lit context and some controllers. Let me know where/how.
Add example
Gabswim
force-pushed
the
feat/lit-query-example
branch
from
b7e9b3d
to
eee8fd4
Compare
| */ | ||
| hostUpdate() { | ||
| const defaultOption = this.getDefaultOptions() | ||
| this.queryObserver.setOptions(defaultOption) |
There was a problem hiding this comment.
This would make the options being set in each lifecycle, which is undesirable. It's preferable to only update the options when they have changed.
| hostConnected() { | ||
| this.unsubscribe = this.queryObserver.subscribe((result) => { | ||
| this.result = result | ||
| this.host.requestUpdate() |
There was a problem hiding this comment.
It's preferable to only requestUpdate when the result has changed since a lot of unnecessary updates is triggered otherwise.
There was a problem hiding this comment.
I was under the impression that this event listener was only going to get called when the result has changed.
There was a problem hiding this comment.
I think you're right. I think all this is handled properly in the queryObserver now.
|
Hello! Thanks a lot for attempting to bridge Lit and Tanstack Query. I tried to make this works locally, just to see. Small, ongoing PR for fixing build, adding a mutation controller, example(s)…: EDIT |
@JulianCataldo Nice to have you onboard! I've made some additions with a context provider also. Gabswim#2 Feel free to try it out. |
Remove unused line Co-authored-by: Gabriel Legault <[email protected]>
|
Context provider is a huge addition. I'll try this as soon as I can :) Ty! |
Query context provider
|
Thank you for your contributions @JulianCataldo ! I saw your PR, but I’ve been more focused on the one for the context provider by @klasjersevi . Before going any further, I think it would be good to get some feedback from @TkDodo, justinfagnani, just to make sure we're all aligned. One challenge, which I believe has no workaround with Lit’s context, is its asynchronous flow. This issue doesn't seem to exist in other packages, as seen in these implementations: |
Just to explain for anyone who is not familiar with Lit Context: Lit context is an event-based protocol between web components based on the Context Community Protocol by the W3C's Web Components Community Group. Normally this happens synchronously as long as the context provider (parent node) is defined before the context consumer is defined. In some cases this can happen in a different order or if the provider is not yet available for any reason. So the context might be available directly or it might be available at a later point. To overcome some of the challenges with this lit also provides a ContextRoot that can take care of requests until the context provider is available. Many other context api:s in other frameworks are synchronous, which instead throws errors instantly if a context isn't available directly. |
This is just a draft PR to follow up on the discussion I started a while ago here: #6390