Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for
React.use()
#7988base: main
Are you sure you want to change the base?
feat: add support for
React.use()
#7988Changes from 99 commits
8cbd6a0
739d023
7fe1d33
757aeab
7c88325
c2a2cb5
d290fca
da88d68
5e2767b
5ec8342
1cae4fe
dc2fad6
c4a1f9e
4530246
7faa2fa
e6583df
4270093
9cdc99d
e704e3d
e5cf4ee
a3ea13e
306bb1f
ef3926a
8993e37
df946eb
091a1b4
05fc6c6
2ecd43f
b6b2d45
34bb74e
739b66a
36d367a
d1184ba
dc85450
0d32020
26d9067
e1c2394
6435af3
d4a2822
88db1b9
cb0fa35
608dc61
608e476
e419146
c7781ee
8491a96
9d0d7fa
97aec78
b09263c
f7b0359
6356ab4
9d3b8bc
d9cf744
001377d
17b4743
55b6c19
4bfa39d
f27f30d
79ec573
05de0fb
25a5957
543f337
9e2147d
648acc2
23ae156
8967bee
7c7ab77
1b24dcb
7ad4230
f1248f2
8461f2a
0275b3d
8a64488
27996a4
011e373
e217605
be6c1f0
6f8b777
9b4e38b
b8cb318
3b33b03
86b8b03
9df70ac
ac8754a
1b7f5d4
1e4f719
4ee2728
2fa83df
9f281f4
540ddd5
b573cc6
c617a08
ae93100
138b126
d3bd66c
7941921
a47709a
0df1dc3
2cbe35a
60f830b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests still pass if we move this block until after the early return:
https://github.com/TanStack/react-query/blob/60f830bcfa9b8b223565a6cee9a9bcb79d4cab32/packages/query-core/src/queryObserver.ts#L654-L657
I guess we should do that ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me, I don't think the positioning was deliberate; probably just put it first to avoid premature debugging