Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NoInfer to useQuery return types #8654

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add NoInfer to useQuery return types #8654

wants to merge 2 commits into from

Conversation

braeden
Copy link

@braeden braeden commented Feb 16, 2025

Partially fixes #8639

TODOs:

  • We should try to push NoInfer upstream into the query-core types (eg. QueryObserverResult)
    • I didn't have extensive time, but didn't have any luck w/o pushing this as close to the usage as possible
    • If ^ doesn't work, I'd probably need some assistance to enumerate other (non-react) codepaths to change similarly.
  • We should try to use native NoInfer from TS (https://devblogs.microsoft.com/typescript/announcing-typescript-5-4-beta/#the-noinfer-utility-type) instead of our own utility -- not 100% what our TS compatibility story is (eg what if a project doesn't have a "native" feature like NoInfer when we publish d.ts files)

@braeden braeden mentioned this pull request Feb 16, 2025
Open
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 16, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 7b5bb5d.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ❌ Failed 3m 15s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 32s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-16 09:50:59 UTC

@TkDodo
Copy link
Collaborator

TkDodo commented Feb 16, 2025

We should try to use native NoInfer from TS

we support TS 5.0 so this is currently not possible

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 16, 2025

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8654

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8654

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8654

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8654

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8654

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8654

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8654

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8654

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8654

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8654

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8654

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8654

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8654

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8654

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8654

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8654

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8654

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8654

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8654

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8654

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8654

commit: 7b5bb5d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: react-query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TData generic can be inferred or specified incorrectly, causing unexpected runtime errors.
2 participants
@braeden @TkDodo