fix: React 18 support for tooltip modal #336
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @tannerlinsley any update on this? Being stuck on beta 38 because of this. |
|
@tannerlinsley Any updates on this? |
|
Hey @tannerlinsley, I know you're pretty busy with other projects but this is a pretty important issue to handle since many of us have already switched to React 18, could you please take a look and potentially merge this? Thank you! |
|
no news? :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might not be the best way to go, but it WFM, @tannerlinsley 😺
I'm not a React person, but as I best understand what is going on, React 18 changed the render API. That new API is picky over portal element destruction and related
setState()calls, c.f. added/moveduseRef()s.Additionally, the location move of
Object.assign()is to handle the element being added in the project implementation.Relevant to #256 #301 #316
Happy to make additional changes, or if you have better ideas please feel free to poach whatever is useful for a better PR.