fix more type errors

TanStack · Jan 7, 2025 · 4c8ba70 · 4c8ba70
1 parent 1458242
commit 4c8ba70
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/examples/vue/sub-components/src/App.vue b/examples/vue/sub-components/src/App.vue
@@ -107,6 +107,7 @@ const expanded = ref<ExpandedState>({})
 const rerender = () => {
   data.value = defaultData
 }
+
 const table = tableHelper.useTable({
   // features and row models are already defined in the tableHelper
   get data() {

diff --git a/packages/angular-table/src/createTableHelper.ts b/packages/angular-table/src/createTableHelper.ts
@@ -1,8 +1,6 @@
-import {
-  constructTableHelper,
-  TableHelperOptions,
-} from './constructTableHelper'
+import { constructTableHelper } from './constructTableHelper'
 import { injectTable } from './injectTable'
+import type { TableHelperOptions } from './constructTableHelper'
 import type { Signal } from '@angular/core'
 import type {
   RowData,
@@ -12,7 +10,7 @@ import type {
   TableOptions,
 } from '@tanstack/table-core'
 
-type TableHelper<
+export type TableHelper<
   TFeatures extends TableFeatures,
   TData extends RowData = any,
 > = Omit<TableHelper_Core<TFeatures, TData>, 'tableCreator'> & {

diff --git a/packages/angular-table/src/flex-render.ts b/packages/angular-table/src/flex-render.ts
@@ -70,7 +70,7 @@ export class FlexRenderDirective<TProps extends NonNullable<unknown>>
 
     if ('table' in this.props) {
       this.experimentalReactivity =
-        (this.props.table as Partial<Table<any, any>>).options
+        (this.props.table as Partial<Table<any, any>>)['options']
           ?.enableExperimentalReactivity ?? false
     }
 

diff --git a/packages/angular-table/tests/createTableHelper.test-d.ts b/packages/angular-table/tests/createTableHelper.test-d.ts
@@ -4,7 +4,8 @@ import {
   createTableHelper,
   stockFeatures,
 } from '../src'
-import type { ColumnDef, StockTableFeatures, Table, TableHelper } from '../src'
+import type { TableHelper } from '../src/createTableHelper'
+import type { ColumnDef, StockFeatures, Table } from '../src'
 
 test('infer data type from TData', () => {
   type TestDataType = { firstName: string; lastName: string; age: number }
@@ -18,11 +19,11 @@ test('infer data type from TData', () => {
   })
 
   expectTypeOf<typeof tableHelper>().toEqualTypeOf<
-    TableHelper<Required<StockTableFeatures>, TestDataType>
+    TableHelper<Required<StockFeatures>, TestDataType>
   >()
 
   expectTypeOf<(typeof tableHelper)['features']>().toEqualTypeOf<
-    Required<StockTableFeatures>
+    Required<StockFeatures>
   >()
 
   const columns = [
@@ -48,7 +49,7 @@ test('infer data type given by injectTable', () => {
   })
 
   expectTypeOf<typeof tableHelper>().toEqualTypeOf<
-    TableHelper<Required<StockTableFeatures>, any>
+    TableHelper<Required<StockFeatures>, any>
   >()
 
   const injectTable = tableHelper.injectTable
@@ -58,6 +59,6 @@ test('infer data type given by injectTable', () => {
   }))
 
   expectTypeOf<typeof table>().toEqualTypeOf<
-    Table<Required<StockTableFeatures>, TestDataType>
+    Table<Required<StockFeatures>, TestDataType>
   >()
 })