Update stackblitz embed src from /simple → /fixed #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/react/simple doesn’t exist examples/react/fixed does exist and seems like the equivalent to “simple”
|
@acusti is attempting to deploy a commit to the Tanstack Team on Vercel. A member of the Team first needs to authorize it. |
fulopkovacs
requested changes
Feb 9, 2024
There was a problem hiding this comment.
Thanks for the fix! basic example (https://github.com/TanStack/ranger/tree/main/examples/react/basic) instead of simple (which does not exist).
same fix as be3b03d applied to the ranger library
|
@fulopkovacs thanks for the quick review! i updated the PR as requested. |
fulopkovacs
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #174
examples/${framework}/simpledoesn’t exist in any of thereact,svelte, orvueexamples foldersexamples/${framework}/fixeddoes exist in all of the framework example folders and seems like the equivalent to “simple”