Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: <Select /> takes array of options rather than object of objects #186

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Feb 16, 2024

The available field now uses type Array<{ label: string; value: string; logo?: string}> rather than Record<string, { label: string; value: string; logo?: string }>

This was the most pain-free way to allow a project to have no frameworks (i.e. tanstack/config will be able to export const frameworks = [], and no framework selector will appear).

Copy link

vercel bot commented Feb 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tanstack-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 11:05pm

Copy link
Contributor

@fulopkovacs fulopkovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@lachlancollins lachlancollins merged commit 346b90a into main Feb 17, 2024
4 checks passed
@lachlancollins lachlancollins deleted the refactor-select branch February 17, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants